From: Jactry Zeng <jzeng@codeweavers.com>
Subject: Re: [PATCH] twain_32: Fix crash by call TWAIN_UserSelect twice.
Message-Id: <4d544297-969e-da28-ae06-5d138c534519@codeweavers.com>
Date: Tue, 1 Jun 2021 22:27:57 +0800
In-Reply-To: <202106012122393190051@uniontech.com>
References: <202106012122393190051@uniontech.com>

Hi,

On 6/1/21 9:22 PM, Jiajin Cui wrote:
>  
>      twain_autodetect();
>  
> +    if (!IsWindow(parent))
> +        parent = *(HWND*)DSM_parent;
> +
If this is true, you would need to remove the following check.
And I think attaching some tests to verify it won't hurt.
>      if (!IsWindow(parent))
>          parent = NULL;

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEENcHKmsHEqfZUIecDmyjwnocwYPQFAmC2Q+0FAwAAAAAACgkQmyjwnocwYPR1
3Qf/eE5EQmhgWMsRPelRGKkb02W+JEcZpAhBstm9+2YFitAzjVmt90+Lp0grzdUK91FyJTqSOuhR
HieYh2xUywSkApap7KZqnffS5JF5aXQLZuSMfRE0woByDia4ght15G2GjJg4qBUAHbeiQKpo91EC
aMvLAMqI7GxeJ7STErGtuBLjlYU+SVqxwMQhBq5it7HFVTcjyE2xJEULbo5a9sbrdWJaUXeIpt5Q
3zLyziD0RzMvgQop3BY+Hlqs9fhxTeLCBx0UgmARB5mubsoFoQB+ygzBJBqWxbl2shw1GCv4DHUD
jNvBE0ZQhifa5rkAwhuICIHnDQNwFeTyGZssf7KyGQ==
=Gsxg
-----END PGP SIGNATURE-----