From: Nikolay Sivov Subject: Re: [PATCH v2] msxml3: Null check new child in insertBefore. Message-Id: <76232759-8b37-fdee-6441-a23d717a8654@codeweavers.com> Date: Thu, 27 May 2021 09:10:02 +0300 In-Reply-To: References: Please split this in two patches, one for document and one for element node. > + /* NULL to document */ > + V_VT(&v) = VT_NULL; > + node = (void*)0xdeadbeef; > + hr = IXMLDOMDocument_insertBefore(doc, (IXMLDOMNode*)NULL, v, &node); > + ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); > + ok(node == (void*)0xdeadbeef, "got %p\n", node); > + You don't need to cast NULL. Please split this in two patches, one for document and one for element node.

+    /* NULL to document */
+    V_VT(&v) = VT_NULL;
+    node = (void*)0xdeadbeef;
+    hr = IXMLDOMDocument_insertBefore(doc, (IXMLDOMNode*)NULL, v, &node);
+    ok(hr == E_INVALIDARG, "got 0x%08x\n", hr);
+    ok(node == (void*)0xdeadbeef, "got %p\n", node);
+
You don't need to cast NULL.