From: "Zebediah Figura (she/her)" Subject: Re: [PATCH vkd3d v2 2/6] vkd3d-shader: Return a vkd3d_string_buffer from hlsl_modifiers_to_string(). Message-Id: <2359c6df-1d96-3add-e39e-74eb56f256be@codeweavers.com> Date: Sat, 27 Feb 2021 18:03:39 -0600 In-Reply-To: References: <20210226184519.755436-1-zfigura@codeweavers.com> <20210226184519.755436-2-zfigura@codeweavers.com> On 2/27/21 3:55 AM, Matteo Bruni wrote: > On Fri, Feb 26, 2021 at 7:45 PM Zebediah Figura wrote: >> >> Signed-off-by: Zebediah Figura >> --- >> libs/vkd3d-shader/hlsl.c | 54 +++++++++++++++++++++------------------- >> libs/vkd3d-shader/hlsl.h | 3 ++- >> libs/vkd3d-shader/hlsl.y | 16 ++++++------ >> 3 files changed, 38 insertions(+), 35 deletions(-) >> >> diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c >> index e2a77707..dbc03a80 100644 >> --- a/libs/vkd3d-shader/hlsl.c >> +++ b/libs/vkd3d-shader/hlsl.c >> @@ -730,46 +730,45 @@ const char *debug_hlsl_type(const struct hlsl_type *type) >> return ret; >> } >> >> -char *hlsl_modifiers_to_string(unsigned int modifiers) >> +struct vkd3d_string_buffer *hlsl_modifiers_to_string(struct vkd3d_string_buffer_list *string_buffers, >> + unsigned int modifiers) > > It looks like this is the old version of the patch, not rebased on top > of patch 1/6 v2. > Sorry about that; resent. -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEENTo75Twe9rbPART3DZ01igeheEAFAmA63dwFAwAAAAAACgkQDZ01igeheEDW swgAmB1IDs9g+HOQB8WrG2JsWWeMD39vHt0An0LkGvo302nSccHRQkzG2Y2pTAvlP/7a+/klmzJz lTZuXwoc1Vkbqw9js/AojzzrP6SXD+PTopV66pPjH9gnnehk1yXzuQiUz3TxVnZkNB9bz5HDfAz+ cuwIcrByczkt7phYQeUnImnFq3SroDSY90MzrqCpp4rT97zl2cqGMd0KDtS4Yv73mwLVLXPFfvtC PlE4a7ltETVzXovtRIw/lL48J/XNOCzGOtOgiR87zsr1P0FvpDxMXi3nnN5JDXUkVX7r05c9p/jz ljuO7YsO48lvGor0D3avIQDGeIv9/u4+aFsS22eyCw== =GK15 -----END PGP SIGNATURE-----