From: Matteo Bruni Subject: Re: [PATCH vkd3d v2 2/6] vkd3d-shader: Return a vkd3d_string_buffer from hlsl_modifiers_to_string(). Message-Id: Date: Sat, 27 Feb 2021 10:55:15 +0100 In-Reply-To: <20210226184519.755436-2-zfigura@codeweavers.com> References: <20210226184519.755436-1-zfigura@codeweavers.com> <20210226184519.755436-2-zfigura@codeweavers.com> On Fri, Feb 26, 2021 at 7:45 PM Zebediah Figura wrote: > > Signed-off-by: Zebediah Figura > --- > libs/vkd3d-shader/hlsl.c | 54 +++++++++++++++++++++------------------- > libs/vkd3d-shader/hlsl.h | 3 ++- > libs/vkd3d-shader/hlsl.y | 16 ++++++------ > 3 files changed, 38 insertions(+), 35 deletions(-) > > diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c > index e2a77707..dbc03a80 100644 > --- a/libs/vkd3d-shader/hlsl.c > +++ b/libs/vkd3d-shader/hlsl.c > @@ -730,46 +730,45 @@ const char *debug_hlsl_type(const struct hlsl_type *type) > return ret; > } > > -char *hlsl_modifiers_to_string(unsigned int modifiers) > +struct vkd3d_string_buffer *hlsl_modifiers_to_string(struct vkd3d_string_buffer_list *string_buffers, > + unsigned int modifiers) It looks like this is the old version of the patch, not rebased on top of patch 1/6 v2.