From: "Esme Povirk (they/them)" Subject: Re: [PATCH] windowscodecs: Add stub implementation for DDS encoder. Message-Id: Date: Thu, 25 Feb 2021 20:40:23 -0600 In-Reply-To: <33f431f5-4bb4-898f-efb5-4564d83f7594@codeweavers.com> References: <33f431f5-4bb4-898f-efb5-4564d83f7594@codeweavers.com> It's a bit strange to use the encoder_info struct without using CommonEncoder. The interface for CommonDecoder and CommonEncoder was designed to be usable without the unixlib, and it does seem to decrease the amount of boilerplate. But, since we need to support IWICDdsEncoder, it probably doesn't make sense to use it in this case. We should probably have a fixme in QueryInterface so we can at least tell when IWICDdsEncoder is used, if not a stub for the interface.