From: "Zebediah Figura (she/her)" Subject: Re: [PATCH] d3d12: Check for VK_KHR_external_fence_capabilities before using VkPhysicalDeviceIDProperties. Message-Id: Date: Thu, 25 Feb 2021 10:38:59 -0600 In-Reply-To: <1ab2f18e-7b35-caf9-4af7-e0ff6c976233@froggi.es> References: <20210224205842.591939-1-z.figura12@gmail.com> <4b8621f3-b9a8-0101-33aa-3b60c11ff0bc@codeweavers.com> <1ab2f18e-7b35-caf9-4af7-e0ff6c976233@froggi.es> On 2/25/21 10:18 AM, Joshua Ashton wrote: > On 2/25/21 4:01 PM, Zebediah Figura (she/her) wrote: >> On 2/25/21 7:00 AM, Joshua Ashton wrote: >>> There is no reason to. This is core in Vulkan 1.1. >>> >>> You should just use a newer API version. >>> There is no relevant driver that doesn't support this. >> >> Mesa's v3dv is an example of a driver that does not support Vulkan 1.1. > > That is not relevant hardware: > It is not capable of supporting D3D12. If it's capable of supporting vkd3d, it's capable of supporting d3d12 ;-) (Granted, the former may actually not be the case, for lack of KHR_shader_draw_parameters. I don't know if that's possible to implement.) More to the point, though, there are more salient reasons to support Vulkan 1.0: drivers not yet written (e.g. there is not yet a free NVidia or Mali driver, nor a conformant software driver), drivers whose latest versions are not accessible (e.g. the last version of MoltenVK that can be built for MacOS Mojave only supports Vulkan 1.0), hardware which may not be capable of supporting Vulkan 1.1 (if any exists), and less painful bisection of Vulkan drivers down to old versions. Compared with the cost of adding a couple lines, and that only because I happened to run the validation layers, I'm not particularly inclined to believe dropping support for Vulkan 1.0 is a worthwhile trade. > > - Joshie 🐸✨ > >> >>> >>> - Joshie 🐸✨ >>> >> > -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEENTo75Twe9rbPART3DZ01igeheEAFAmA30qMFAwAAAAAACgkQDZ01igeheEDJ uAf/a2ot/LGq0Z/5lTySZFwPAaPZCMo9Pr45Ck9//xETiIlgoFE9pVolzf05tdXPevfUj7r0Xo2G CW6k4sPAyBN6qR2k924KxPi98jNnRttwAO3W3zLytmAGqY8awMxJWoC4vKVOJ2h1ciVeT+rn5nPK +xPtfRqdtGyib343OUKY4BKkZNDqShn4hTIdPYfCac9eiohaM+t2Ywj2p2AdRNhQIsYS2OEdlChd vCZmAkdTTcNI3PHed92xWZuRgzYLBMvqQvFkV0VZ2/hjTIC/F3wbtoTw2ak0oyBUBGnd3i6k8h4a f21GMwtM04QBurjJWGpUtprlUtEgE/RRenUf1B961w== =bMQD -----END PGP SIGNATURE-----