From: "Rémi Bernon" Subject: Re: [PATCH 3/5] server: Move the cursor position and last change time to the shared data. Message-Id: <62fb6d2e-7771-bc48-ecd9-9df765d39006@codeweavers.com> Date: Thu, 19 Nov 2020 15:12:48 +0100 In-Reply-To: References: <20201119130931.89653-3-huw@codeweavers.com> <294c9baa-5f40-ff73-aa9c-fb70e1d987c5@codeweavers.com> On 11/19/20 3:01 PM, Huw Davies wrote: > On 19 Nov 2020, at 13:42, Rémi Bernon wrote: >> On 11/19/20 2:09 PM, Huw Davies wrote: >>> Signed-off-by: Huw Davies >>> --- >>> server/protocol.def | 9 ++++++- >>> server/queue.c | 62 ++++++++++++++++++++++----------------------- >>> server/user.h | 3 --- >>> 3 files changed, 39 insertions(+), 35 deletions(-) >>> >> Just a quick thought, as the shared desktop data struct is flagged volatile, this will probably prevent optimizations on the server-side reads too, maybe we could avoid that and only make the writes volatile? > > Hmm, interesting idea. That would most likely involve volatile casts > while writing (or macros to hide them), neither of which are > particularly appealing. I'd be tempted to wait to see if this becomes > a real issue before doing this, but I'm open to being persuaded otherwise. > > Huw. > We could also keep the non-shared state like it is and add a separate shared state that gets updated with the non-shared state, in the helper? -- Rémi Bernon