From: Huw Davies Subject: Re: [PATCH v2 5/7] gdi32: Handle zero-width control characters in get_glyph_outline. Message-Id: <20201112093814.GC15687@merlot.physics.ox.ac.uk> Date: Thu, 12 Nov 2020 09:38:16 +0000 In-Reply-To: <20201109140720.472712-5-sbaars@codeweavers.com> References: <20201109140720.472712-1-sbaars@codeweavers.com> <20201109140720.472712-5-sbaars@codeweavers.com> On Mon, Nov 09, 2020 at 03:07:17PM +0100, Sven Baars wrote: > { > + todo_wine { > ok(len > 0, "Test %d: got %d.\n", i, len); > ok(abc.abcA + abc.abcB + abc.abcC <= len && abc.abcA + abc.abcB + abc.abcC > 0, > "Test %d: expected %d >= %d > 0.\n", i, len, abc.abcA + abc.abcB + abc.abcC); > ok(abc.abcB > 0, "Test %d: got %d.\n", i, abc.abcB); > + } > } I haven't looked at this in any detail, but if your changes require adding todo_wine blocks that's going to require a lot of justification. Huw.