From: Hans Leidekker <hans@codeweavers.com>
Subject: Re: [PATCH 3/3] msado15: Implement ADORecordsetConstruction get/put Rowset
Message-Id: <934c8b2d1a46374094f4dce5be86a91b4cf44208.camel@codeweavers.com>
Date: Fri, 30 Oct 2020 10:09:05 +0100
In-Reply-To: <SLXP216MB0621FC6EB3863AEF16D6871193150@SLXP216MB0621.KORP216.PROD.OUTLOOK.COM>
References: <20201030075058.4739-1-leslie_alistair@hotmail.com> <SLXP216MB0621FC6EB3863AEF16D6871193150@SLXP216MB0621.KORP216.PROD.OUTLOOK.COM>

On Fri, 2020-10-30 at 18:50 +1100, Alistair Leslie-Hughes wrote: 
>  static HRESULT WINAPI rsconstruction_put_Rowset(ADORecordsetConstruction *iface, IUnknown *row_set)
>  {
>      struct recordset *recordset = impl_from_ADORecordsetConstruction( iface );
> -    FIXME("%p, %p\n", recordset, row_set);
> -    return E_NOTIMPL;
> +
> +    TRACE("%p, %p\n", recordset, row_set);
> +
> +    if (recordset->row_set) IUnknown_Release(recordset->row_set);
> +    recordset->row_set = row_set;
> +    if (recordset->row_set) IUnknown_AddRef(recordset->row_set);
> +
> +    return S_OK;
>  }

This is supposed to turn the row_set into a Recordset object but
you only store a reference. This could use some tests around
the interaction between these objects.