From: Vijay Kiran Kamuju Subject: Re: [PATCH 4/4] ntoskrnl.exe: Add stub RtlLookupElementGenericTable function Message-Id: Date: Thu, 29 Oct 2020 15:00:51 +0100 In-Reply-To: <571e5e05-eacf-c4a0-4e06-caddebdefb54@codeweavers.com> References: <571e5e05-eacf-c4a0-4e06-caddebdefb54@codeweavers.com> On Thu, Oct 29, 2020 at 2:54 PM Paul Gofman wrote: > > On 10/29/20 16:49, Vijay Kiran Kamuju wrote: > > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49426 > > Signed-off-by: Vijay Kiran Kamuju > > Do these stubs actually allow the application to run normally? If not > (as I would expect, as the application is unlikely just checking their > presence), maybe it would make more sense to implement them at once > instead of stubbing? They seem to be fully documented. > It should allow them to run as per the documentation if the item is not found or if it's out of bounds it should return NULL. It would be better to implement them completely along with their AVL counterparts.