From: "Esme Povirk (they/them)" <esme@codeweavers.com>
Subject: Re: [PATCH v4 7/7] wmphoto: Implement WmpDecoder using jxrlib.
Message-Id: <CAAFPtVRnHh9j=TcjZzd0UoEDwXeZ5AA+yM6D9m-68AuAyEtWtA@mail.gmail.com>
Date: Wed, 23 Sep 2020 14:27:56 -0500
In-Reply-To: <20200923114946.1208468-7-rbernon@codeweavers.com>
References: <20200923114946.1208468-1-rbernon@codeweavers.com> <20200923114946.1208468-7-rbernon@codeweavers.com>

-        todo_wine_if(test_image[i].expected.ImageFileFormat == D3DX10_IFF_WMP)
+        todo_wine_if(test_image[i].expected.ImageFileFormat ==
D3DX10_IFF_WMP && hr == E_FAIL) /* JPEG-XR support is optional */

We should remove the todo_wine. If something isn't working because of
a missing dependency, it's not working as far as the tests are
concerned.

I had a thought about multiple frames. Maybe we should just create the
object in Initialize to get the number of frames, and make a new one
for each frame. (But I don't think it's necessary to figure that out
right now.)