From: "Rémi Bernon" Subject: Re: [PATCH v3 4/4] gdi32: Split create_face to a separate function. Message-Id: Date: Mon, 21 Sep 2020 11:08:26 +0200 In-Reply-To: <20200921090242.GD24050@merlot.physics.ox.ac.uk> References: <20200917173045.1315058-1-rbernon@codeweavers.com> <20200917173045.1315058-4-rbernon@codeweavers.com> <20200921090242.GD24050@merlot.physics.ox.ac.uk> On 2020-09-21 11:02, Huw Davies wrote: > On Thu, Sep 17, 2020 at 07:30:45PM +0200, Rémi Bernon wrote: >> Make it not depend on FreeType so we can also use it before creating >> FT_Face. >> >> We also open and fstat the file first, checking for its existence and >> in preparation for mmaping it to parse the font info later. > > This is probably fine as it stands, but it would be good to see a bit > more of where you're going before making this change. > > Huw. > Sure, here's where I currently intend to go: https://gitlab.com/rbernon/wine/-/commits/wip/freetype/v3/ I'll probably also drop the FreeType cache manager usage, as it's not really useful anymore (since we won't be loading so many fonts with FreeType). I had some additional patches that use it for all FreeType code in gdi32 (including for GdiFont), but I need to sort out some issues related to font lifecycle and some internal cache first. -- Rémi Bernon