From: Huw Davies Subject: Re: [PATCH v3 4/4] gdi32: Split create_face to a separate function. Message-Id: <20200921090242.GD24050@merlot.physics.ox.ac.uk> Date: Mon, 21 Sep 2020 10:02:43 +0100 In-Reply-To: <20200917173045.1315058-4-rbernon@codeweavers.com> References: <20200917173045.1315058-1-rbernon@codeweavers.com> <20200917173045.1315058-4-rbernon@codeweavers.com> On Thu, Sep 17, 2020 at 07:30:45PM +0200, Rémi Bernon wrote: > Make it not depend on FreeType so we can also use it before creating > FT_Face. > > We also open and fstat the file first, checking for its existence and > in preparation for mmaping it to parse the font info later. This is probably fine as it stands, but it would be good to see a bit more of where you're going before making this change. Huw.