From: Brendan Shanks Subject: Re: [PATCH 5/5] winevulkan: Add executable name Quirk regkey handling Message-Id: <3326A230-6BF6-4B2A-B409-82B47A3887FA@codeweavers.com> Date: Tue, 15 Sep 2020 12:54:15 -0700 In-Reply-To: References: <20200914123146.12912-1-lmiddlebrook@nvidia.com> <20200914123146.12912-5-lmiddlebrook@nvidia.com> <87bli7iiiq.fsf@wine> <83cab73b-1b69-92af-2ff1-a8ca3c9878f0@nvidia.com> > On Sep 15, 2020, at 5:33 AM, Henri Verbeet wrote: > > On Tue, 15 Sep 2020 at 16:13, Liam Middlebrook wrote: >> Additionally, this information is already being used within WineVulkan >> to match the idTech engine [2]. There are also a few different Vulkan >> driver implementations [3], [4], [5], which use this for enabling >> per-application/per-engine settings. >> > Incidentally, I absolutely *hate* drivers that do this kind of thing, > particularly the overly broad variants like the "vkd3d" example in [4] > above, or the simply *broken* variants like [6]/[7] where the default > configuration is broken to work around an application bug in a > non-default configuration. > > Back on-topic though—and I think what Alexandre was referring to—do we > really think there's a case in practice for users to apply quirks > based on e.g. the internal engine name, instead of simply the > executable name? I don’t know of a real-world example where this has been necessary, but one theoretical case is that an app with a generic name like “Game.exe” or “Launcher.exe” (but a unique application/engine name) needs a quirk or override applied. Maybe this is too remote a possibility to add it preemptively though. Also Liam, in case it’s decided to go ahead with this, since pApplicationInfo and pEngineName are UTF-8, should they be converted to UTF-16 and Unicode registry functions be used? Brendan