From: Haoyang Chen Subject: Re: [PATCH] shell32: Skip OpenAs_RunDLL in uri Message-Id: Date: Thu, 10 Sep 2020 14:55:40 +0800 In-Reply-To: <2bfd3387-a628-8ca5-86ab-9f3080502be5@codeweavers.com> References: <157fd464-43aa-3a9b-c018-1da2555f1f1c@codeweavers.com> <16d084ba-35cf-a59f-8f4a-d10737fe0222@uniontech.com> <13bcedce-cc7c-eb68-6674-ff7e1c9d1ced@codeweavers.com> <2bfd3387-a628-8ca5-86ab-9f3080502be5@codeweavers.com> I think about it.  For OpenAs_RunDLL() , or SHOpenWithDialog(), the user can select an app or register the file association method. The trouble is whether this is for the native system or wine. This commit should be rejected, like a hack. 在 2020/9/8 下午9:26, Nikolay Sivov 写道: > > On 9/8/20 1:58 PM, Haoyang Chen wrote: >> It will definitely open an "Open With" dialog box and let the user >> choose which application to use to open the URI. Even if the default >> application is indicated in the registry, it will be opened. I don't >> know much about the implementation of this function. My idea is >> simple, just skip it and let shellexecute use the default registry >> program to open it. > That will run things automatically, when normally user has control to > cancel it. > >> 在 2020/9/8 下午6:07, Nikolay Sivov 写道: >>> On 9/8/20 12:28 PM, Haoyang Chen wrote: >>>> Through windows 7,  I found that OpenAs_RunDLL functions will open a >>>> dialog that can choose to specify the application. my idea is to skip >>>> this OpenAs_RunDLL and use wine's default application execution. >>>> >>>> eg: ShellExecuteW(NULL,  L"open", L"rundll32.exe", L"shell32.dll, >>>> OpenAs_RunDLL https://www.winehq.org/", NULL,  SW_SHOW); >>> If it's only meant to open a dialog, why would you shellexec instead? >>> >>> P.S. please cc wine-devel on replies. >>> >>>> 在 2020/9/8 下午3:57, Nikolay Sivov 写道: >>>>> It's probably easier to implement OpenAs_RunDLL(). What is the full >>>>> command line and what is supposed to happen on OpenAs_RunDLL() call? >>>>> >>>>> >>>>> >>>>> >>> >>> >>> >> > > > >