From: Jeff Smith <whydoubt@gmail.com>
Subject: Re: [PATCH] d3d9: CreateDevice() requires a valid window to be passed in.
Message-Id: <CAPX7N=6KQPiLpTmeS70UuK3icuqAS83o-3GX5s3oNvKJ3w06XA@mail.gmail.com>
Date: Wed, 9 Sep 2020 12:54:50 -0500
In-Reply-To: <ac9a4cfc-cc14-5167-f73b-75b013e4832e@gmail.com>
References: <20200908060212.463849-1-whydoubt@gmail.com> <ac9a4cfc-cc14-5167-f73b-75b013e4832e@gmail.com>

On Tue, Sep 8, 2020 at 5:50 AM Stefan Dösinger
<stefandoesinger@gmail.com> wrote:
>
> Am 08.09.20 um 09:02 schrieb Jeff Smith:
> > +    hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, NULL,
> > +            behavior_flags, &present_parameters, &device);
>
> Is this true of all device types? In particular, also NULLREF? I think
> WPF creates NULLREF devices with NULL windows, although I am not sure
> what for...

Yes, it does appear that CreateDevice with other D3DDEVTYPEs does
behave differently,
particularly NULLREF.  I am trying to improve the tests and solution,
but am running into a
bug with NULLREF that is causing it to fail on some platforms but not others.

Thanks,
Jeff