From: Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH v2 1/2] ntdll: Fix KiUserExceptionDispatcher ABI on x86.
Message-Id: <87y2o0537l.fsf@wine>
Date: Fri, 03 Jul 2020 11:59:26 +0200
In-Reply-To: <20200702134708.727988-1-pgofman@codeweavers.com> (Paul Gofman's message of "Thu, 2 Jul 2020 16:47:07 +0300")
References: <20200702134708.727988-1-pgofman@codeweavers.com>

Paul Gofman <pgofman@codeweavers.com> writes:

> -void WINAPI call_user_exception_dispatcher( EXCEPTION_RECORD *rec, CONTEXT *context )
> +void *get_KiUserExceptionDispatcher_address(void)
>  {
> -    pKiUserExceptionDispatcher( rec, context );
> +    return pKiUserExceptionDispatcher;
>  }
>  
> +__ASM_GLOBAL_FUNC( call_user_exception_dispatcher,
> +                   "add $4,%esp\n\t"
> +                   "call " __ASM_NAME("get_KiUserExceptionDispatcher_address") "\n\t"
> +                   "jmp *%eax")

That's not very nice. I'd suggest to pass the dispatcher address to
call_user_exception_dispatcher().

-- 
Alexandre Julliard
julliard@winehq.org