From: Myah Caron Subject: Re: [PATCH] msvcrt: Don't set MXCSR in _control87. Message-Id: Date: Fri, 03 Jul 2020 08:24:50 +0000 In-Reply-To: <87eept5atd.fsf@wine> References: <87eept5atd.fsf@wine> Thank you! I'll extend the test and hopefully also find a solution that mimics Windows's behavior :) ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, July 3, 2020 12:15 AM, Alexandre Julliard wrote: > Myah Caron qsniyg@protonmail.com writes: > > > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27594 > > Signed-off-by: Myah Caron qsniyg@protonmail.com > > > > -------------------------------------------------------------------------------------------------------- > > > > This appears to match native MSVCRT's behavior, at least the one provided by vcrun6. > > It's not obvious because the tests are in kernel32, but we are > definitely supposed to set it: > > ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe thread && touch thread.ok > thread.c:1915: Test failed: expected 0x20301 got 0x80020301 > thread.c:1916: Test failed: expected 0x70000c60 got 0x1f800c60 > thread.c:1926: Test failed: expected 0x20301 got 0x80020301 > thread.c:1927: Test failed: expected 0x70000c60 got 0x1f800c60 > make: *** [Makefile:948: thread.ok] Error 4 > > Looking at your test case, it may be that we shouldn't set it when the > FPU control word didn't change. You should extend the tests in thread.c. > > ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Alexandre Julliard > julliard@winehq.org