From: "Chip Davis" <cdavis@codeweavers.com>
Subject: Re: [PATCH vkd3d 3/5] vkd3d-compiler: Add an explicit --help option.
Message-Id: <305959e130490e9aadc16011e990af0e@codeweavers.com>
Date: Thu, 02 Jul 2020 23:34:28 +0000
In-Reply-To: <20200702134316.14971-3-hverbeet@codeweavers.com>
References: <20200702134316.14971-3-hverbeet@codeweavers.com>

July 2, 2020 8:43 AM, "Henri Verbeet" <hverbeet@codeweavers.com> wrote:

> diff --git a/programs/vkd3d-compiler/main.c b/programs/vkd3d-compiler/main.c
> index 8fa4d4f..e975572 100644
> --- a/programs/vkd3d-compiler/main.c
> +++ b/programs/vkd3d-compiler/main.c
> @@ -147,6 +150,7 @@ static bool parse_command_line(int argc, char **argv, struct options *options)
> 
>      static struct option long_options[] =
>      {
> +        {"help",        no_argument, NULL, OPTION_HELP},

You know that if you have a long option that aliases a short option, you can just use the short option char as the code for the long option, right?

>          {"strip-debug", no_argument, NULL, OPTION_STRIP_DEBUG},
>          {NULL,          0,           NULL, 0},
>      };

Chip