From: Zhiyi Zhang Subject: Re: [PATCH] user32/tests: Fix test that has been successful. Message-Id: <73db7b07-7979-d12a-d0d1-2758dad14b8a@codeweavers.com> Date: Thu, 2 Jul 2020 10:45:11 +0800 In-Reply-To: <202007021015340447220@uniontech.com> References: <202007021015340447220@uniontech.com> On 7/2/20 10:15 AM, Jiajin Cui wrote: > > 0001-user32-tests-Fix-test-that-has-been-successful.patch > > From 5c3930407ac0e313121d56f760e4ad998f233e65 Mon Sep 17 00:00:00 2001 > From: Jiajin Cui > Date: Thu, 2 Jul 2020 09:59:46 +0800 > Subject: [PATCH] user32/tests: Fix test that has been successful. > > Someone has fixed the issue of the ShowWindow parameter as SW_MINIMIZE, but no fix to the test code. > > Signed-off-by: Jiajin Cui > --- > dlls/user32/tests/msg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c > index f84525a0bf..51091e3408 100644 > --- a/dlls/user32/tests/msg.c > +++ b/dlls/user32/tests/msg.c > @@ -5186,7 +5186,7 @@ static void test_messages(void) > > ShowWindow(hwnd, SW_MINIMIZE); > flush_events(); > - ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE); > + ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE); > flush_sequence(); > > if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE) See https://www.winehq.org/pipermail/wine-devel/2019-May/146430.html It is not fixed on FVWM, which is the window manager that TestBots use.

On 7/2/20 10:15 AM, Jiajin Cui wrote:

      

      
0001-user32-tests-Fix-test-that-has-been-successful.patch

      
From 5c3930407ac0e313121d56f760e4ad998f233e65 Mon Sep 17 00:00:00 2001
From: Jiajin Cui <cuijiajin@uniontech.com>
Date: Thu, 2 Jul 2020 09:59:46 +0800
Subject: [PATCH] user32/tests: Fix test that has been successful.

Someone has fixed the issue of the ShowWindow parameter as SW_MINIMIZE, but no fix to the test code.

Signed-off-by: Jiajin Cui <cuijiajin@uniontech.com>
---
 dlls/user32/tests/msg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index f84525a0bf..51091e3408 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -5186,7 +5186,7 @@ static void test_messages(void)
 
     ShowWindow(hwnd, SW_MINIMIZE);
     flush_events();
-    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
+    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
     flush_sequence();
 
     if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)


    

    See https://www.winehq.org/pipermail/wine-devel/2019-May/146430.html

    It is not fixed on FVWM, which is the window manager that TestBots
    use.