From: Alex Henrie Subject: Re: [PATCH v2 0/2] Improved file association desktop integration Message-Id: Date: Mon, 29 Jun 2020 13:44:46 -0600 In-Reply-To: References: <20200624071127.109241-1-alexhenrie24@gmail.com> On Thu, Jun 25, 2020 at 3:29 AM Francois Gouget wrote: > > On Wed, 24 Jun 2020, Alex Henrie wrote: > > > The big change here is rewriting the patches to avoid the term > > "blacklist", which I have replaced with "naughty list". > > In this context it's not clear what naughty means. What in a file > extension is "badly behaved, disobedient or mildly rude or indecent"? Several built-in Wine programs are badly behaved in the sense that they associate themselves with file types that native desktop programs are better suited to open. > I want for proof that you have to explain what it means in the code: > > + if (on_naughty_list(extensionW, commandW)) > > + /* command is on naughty list => desktop integration is not desirable */ > > Also, this being a key name, is "List" even needed? After all the > "Classes" key is not called "ClassesList". > > So I think something like "FileOpenIgnore" would be clearer, > although a wording more explicitly related to desktop integration > may be even better. "FileOpenInWineOnly", "NotExportedExtensions" or > "WineOnlyExtensions"? The word "extension" is problematic because the naughty list includes both extensions (which start with a dot) and protocols (which do not). How about "FileOpenNoIntegration"? -Alex