From: Vijay Kiran Kamuju Subject: [PATCH V2 3/3] dsdmo: Implement IDirectSoundFXEcho::SetAllParameters. Message-Id: Date: Thu, 25 Jun 2020 15:29:13 +0200 Signed-off-by: Vijay Kiran Kamuju From b59efc89d7aa43c87c8cce0dd85be888577f05d9 Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Mon, 9 Sep 2019 10:20:50 +1000 Subject: [PATCH V2 3/3] dsdmo: Implement IDirectSoundFXEcho::SetAllParameters. Signed-off-by: Vijay Kiran Kamuju --- dlls/dsdmo/echo.c | 20 ++++++++++++++++++-- dlls/dsound/tests/dsound8.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/dlls/dsdmo/echo.c b/dlls/dsdmo/echo.c index e9add8a019..f0084dca24 100644 --- a/dlls/dsdmo/echo.c +++ b/dlls/dsdmo/echo.c @@ -352,9 +352,25 @@ static ULONG WINAPI echofx_Release(IDirectSoundFXEcho *iface) static HRESULT WINAPI echofx_SetAllParameters(IDirectSoundFXEcho *iface, const DSFXEcho *echo) { struct dmo_echofx *This = impl_from_IDirectSoundFXEcho(iface); - FIXME("(%p) %p\n", This, echo); - return E_NOTIMPL; + TRACE("(%p) %p\n", This, echo); + + if(!echo) + return E_POINTER; + + /* Out of Range values */ + if( (echo->fWetDryMix < DSFXECHO_WETDRYMIX_MIN || echo->fWetDryMix > DSFXECHO_WETDRYMIX_MAX) || + (echo->fFeedback < DSFXECHO_FEEDBACK_MIN || echo->fFeedback > DSFXECHO_FEEDBACK_MAX) || + (echo->fLeftDelay < DSFXECHO_LEFTDELAY_MIN || echo->fLeftDelay > DSFXECHO_LEFTDELAY_MAX) || + (echo->fRightDelay < DSFXECHO_RIGHTDELAY_MIN || echo->fRightDelay > DSFXECHO_RIGHTDELAY_MAX) || + (echo->lPanDelay != DSFXECHO_PANDELAY_MIN && echo->lPanDelay != DSFXECHO_PANDELAY_MAX) ) + { + return E_INVALIDARG; + } + + This->params = *echo; + + return S_OK; } static HRESULT WINAPI echofx_GetAllParameters(IDirectSoundFXEcho *iface, DSFXEcho *echo) diff --git a/dlls/dsound/tests/dsound8.c b/dlls/dsound/tests/dsound8.c index 6d42dedee4..47cb60d062 100644 --- a/dlls/dsound/tests/dsound8.c +++ b/dlls/dsound/tests/dsound8.c @@ -1478,6 +1478,35 @@ static void test_echo_parameters(IDirectSoundBuffer8 *secondary8) test_dsfx_interfaces("FXEcho", (IUnknown *)echo, &IID_IDirectSoundFXEcho); + rc = IDirectSoundFXEcho_SetAllParameters(echo, NULL); + ok(rc == E_POINTER, "got: %08x\n", rc); + + /* Out of range Min */ + params.fWetDryMix = -1.0f; + + rc = IDirectSoundFXEcho_SetAllParameters(echo, ¶ms); + ok(rc == E_INVALIDARG, "got: %08x\n", rc); + + /* Out of range Max */ + params.fWetDryMix = 101.0f; + + rc = IDirectSoundFXEcho_SetAllParameters(echo, ¶ms); + ok(rc == E_INVALIDARG, "got: %08x\n", rc); + + params.fWetDryMix = DSFXECHO_WETDRYMIX_MIN; + + rc = IDirectSoundFXEcho_SetAllParameters(echo, ¶ms); + ok(rc == S_OK, "Failed: %08x\n", rc); + + rc = IDirectSoundFXEcho_GetAllParameters(echo, ¶ms); + ok(rc == DS_OK, "Failed: %08x\n", rc); + + ok(params.fWetDryMix == DSFXECHO_WETDRYMIX_MIN, "got %f\n", params.fWetDryMix); + ok(params.fFeedback == 50.0f, "got %f\n", params.fFeedback); + ok(params.fLeftDelay == 500.0f,"got %f\n", params.fLeftDelay); + ok(params.fRightDelay == 500.0f,"got %f\n", params.fRightDelay); + ok(params.lPanDelay == 0, "got %d\n", params.lPanDelay); + IDirectSoundFXEcho_Release(echo); } } -- 2.27.0