From: Paul Gofman Subject: Re: [PATCH 4/5] wined3d: Don't free system memory when setting user memory for mipmaps. Message-Id: Date: Mon, 15 Jun 2020 21:06:04 +0300 In-Reply-To: References: <20200614181638.168694-1-pgofman@codeweavers.com> <20200614181638.168694-4-pgofman@codeweavers.com> On 6/15/20 19:06, Henri Verbeet wrote: > On Sun, 14 Jun 2020 at 22:47, Paul Gofman wrote: >> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49375 >> Signed-off-by: Paul Gofman >> --- >> dlls/ddraw/tests/ddraw7.c | 2 +- >> dlls/wined3d/texture.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> > I think we would like to free that memory eventually though, if we > can. Perhaps we could do something similar to what > wined3d_texture_update_map_binding() does for PBOs? I suppose we can check if there are any NULL user_memory left when setting the pointer, and free system memory if there are none.