From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH v2 3/5] ddraw/tests: Test cursor clipping.
Message-Id: <CAOsNvwzvpMtPu2Hn1Eue9fK9oyM+vOOnNwdS6VUZN4o3V=o2nw@mail.gmail.com>
Date: Wed, 8 Apr 2020 19:00:39 +0430
In-Reply-To: <0c1815e2-ab57-e6be-1883-786657f22773@codeweavers.com>
References: <0c1815e2-ab57-e6be-1883-786657f22773@codeweavers.com>

On Wed, 8 Apr 2020 at 14:31, Zhiyi Zhang <zzhang@codeweavers.com> wrote:
>
> Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
> ---
>  dlls/ddraw/tests/ddraw7.c | 168 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 168 insertions(+)
>
We can probably get rid of the existing cursor clipping tests from
ddrawmodes.c as well. Do you have tests for the other ddraw versions
as well?

> +    hr = IDirectDraw7_SetDisplayMode(ddraw, param.new_width, param.new_height,
> +            registry_mode.dmBitsPerPel, 0, 0);
It probably doesn't make a difference here, but note that we have a
set_display_mode() helper.