From: "Rémi Bernon" Subject: Re: [PATCH 3/3] winedbg: Support QThreadEvents request. Message-Id: <5706f2ee-a6c7-1a64-8bf9-00fbbb1d0dd1@codeweavers.com> Date: Tue, 7 Apr 2020 22:12:43 +0200 In-Reply-To: References: <20200407173418.1432057-1-rbernon@codeweavers.com> <20200407173418.1432057-3-rbernon@codeweavers.com> On 4/7/20 10:01 PM, Rémi Bernon wrote: > On 4/7/20 7:34 PM, Rémi Bernon wrote: >> @@ -886,6 +891,8 @@ static enum packet_return >> packet_reply_status(struct gdb_context* gdbctx) >>           packet_reply_open(gdbctx); >>           packet_reply_add(gdbctx, "T"); >>           packet_reply_val(gdbctx, >> signal_from_debug_event(&gdbctx->de), 1); >> +        if (gdbctx->de.dwDebugEventCode == CREATE_THREAD_DEBUG_EVENT) >> +            packet_reply_add(gdbctx, "create:"); > > This should actually be "create:;", to fit in the semicolon-separated > list. I'll update and resend this one. > On second thought this is not really useful after all, gdb doesn't even send that request by default, I think I added it for lldb. Please, just ignore this patch. I believe the referenced bug is still already fixed by the previous patches, though. -- Rémi Bernon