From: Zhiyi Zhang Subject: Re: [PATCH] dlls/dxgi: Implement IDXGIFactory5::CheckFeatureSupport. Message-Id: Date: Thu, 2 Apr 2020 09:59:12 +0800 In-Reply-To: <888a4f46167a0f34f6e8d2520ff1eabe@codeweavers.com> References: <0c1ed357-9432-1f52-3c65-34a36838412c@codeweavers.com> <20200331111941.15956-1-post@arntzen-software.no> <888a4f46167a0f34f6e8d2520ff1eabe@codeweavers.com> On 4/2/20 1:42 AM, Chip Davis wrote: > April 1, 2020 10:14 AM, "Zhiyi Zhang" wrote: > >> It's would be better to use a switch statement rather than a if >> because there are other features. > What other features? The only one in the header, and the only one documented, is DXGI_FEATURE_PRESENT_ALLOW_TEARING. > > Chip Sorry. You're right. Turns out I was mixing ID3D12Device::CheckFeatureSupport and IDXGIFactory5::CheckFeatureSupport.