From: "Rémi Bernon" Subject: Re: [RFC PATCH 4/5] wineboot: Disable prefix update if overlays are used. Message-Id: <393bacc9-417d-a588-b6e7-058b2a4afa65@codeweavers.com> Date: Mon, 30 Mar 2020 17:17:12 +0200 In-Reply-To: <5042c5bd-09d2-8102-394c-d5abcfcacacf@gmail.com> References: <20200330122430.2945061-1-rbernon@codeweavers.com> <20200330122430.2945061-5-rbernon@codeweavers.com> <5042c5bd-09d2-8102-394c-d5abcfcacacf@gmail.com> On 3/30/20 5:09 PM, Zebediah Figura wrote: > On 3/30/20 7:24 AM, Rémi Bernon wrote: >> Updating the prefix with overlays enabled creates all sort of yet >> unsolved problems, and will update the upper dir, defeating the purpose >> of using overlays. >> --- > > Presumably you only want to skip the parts that write files here, > though. Otherwise the registry won't get updated. > I started changing setupapi to avoid unnecessary dll updates, but then there's the nls files that gets written, and possibly other things. There's then the problem of reconciling multiple layers with conflicting registry updates, it's not just a question of filesystem state. It was simpler for a PoC to just avoid these issues and say that prefix updates are disabled when overlays are used. I think it can still be a valid use case if the wine version is fixed and several applications want to share the same base layer and avoid duplication.