From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Subject: Re: [PATCH v2 1/2] d3dx9_36: Handle NULL palette
Message-Id: <PS2P216MB0417573C32201AA1A4253D8F93F30@PS2P216MB0417.KORP216.PROD.OUTLOOK.COM>
Date: Sun, 22 Mar 2020 21:46:40 +0000
In-Reply-To: <PS2P216MB04175226140932EA656FB64293F30@PS2P216MB0417.KORP216.PROD.OUTLOOK.COM>
References: <PS2P216MB04175226140932EA656FB64293F30@PS2P216MB0417.KORP216.PROD.OUTLOOK.COM>

Just Ignore this more for now, the second patch in the series can be 
applied without this one.

On 22/3/20 3:05 pm, Alistair Leslie-Hughes wrote:
> D3DFMT_P8 don't have a palette and cause a if they have to_rgba function.
> 
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
> ---
>   dlls/d3dx9_36/surface.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c
> index 42e7bf16f1..e2b398345c 100644
> --- a/dlls/d3dx9_36/surface.c
> +++ b/dlls/d3dx9_36/surface.c
> @@ -1796,7 +1796,7 @@ void point_filter_argb_pixels(const BYTE *src, UINT src_row_pitch, UINT src_slic
>                       struct vec4 color, tmp;
>   
>                       format_to_vec4(src_format, src_ptr, &color);
> -                    if (src_format->to_rgba)
> +                    if (src_format->to_rgba && palette)
>                           src_format->to_rgba(&color, &tmp, palette);
>                       else
>                           tmp = color;
>