From: Alex Henrie <alexhenrie24@gmail.com>
Subject: Re: [PATCH 3/3] iphlpapi: Implement ParseNetworkString for IPv6 addresses and services
Message-Id: <CAMMLpeSpq1ro+Y-ZsnU0N7gKg63JCD_Gt8LfLCw_BSBqBEBLWQ@mail.gmail.com>
Date: Thu, 19 Mar 2020 19:50:04 -0600
In-Reply-To: <123d7e8c-64f7-0bab-3c74-feab1b072159@codeweavers.com>
References: <20200319030638.43405-1-alexhenrie24@gmail.com> <20200319030638.43405-3-alexhenrie24@gmail.com> <123d7e8c-64f7-0bab-3c74-feab1b072159@codeweavers.com>

On Wed, Mar 18, 2020 at 11:06 PM Nikolay Sivov <nsivov@codeweavers.com> wrote:
>
> On 3/19/20 6:06 AM, Alex Henrie wrote:
> > +    if (type & NET_STRING_IPV6_ADDRESS)
> > +    {
> > +        status = RtlIpv6StringToAddressExW(str, &temp_addr6, &temp_scope, &temp_port);
> > +        if (SUCCEEDED(status) && !temp_port)
> > +        {
> NTSTATUS is usually checked for 0 aka STATUS_SUCCESS.

Hmm, ParseNetworkString already has code that uses the SUCCEEDED macro
instead of checking specifically for STATUS_SUCCESS. If Alexandre
rejects the patch over it, I'll resend and correct all four uses of
SUCCEEDED at the same time.

-Alex