From: Zebediah Figura Subject: Re: [PATCH v2] winecfg: don't trash app names Message-Id: <1654b706-347a-454e-d63c-9cd9c4ff98fc@gmail.com> Date: Wed, 18 Mar 2020 13:33:48 -0500 In-Reply-To: <20200318175846.GA7428@blackspire3> References: <20200318153313.GA3064@blackspire3> <20200318175846.GA7428@blackspire3> On 3/18/20 12:58 PM, Rafał Mużyło wrote: > Currently, if app name isn't representable in CP_ACP, it gets trashed > during creation. There's no reason for it - the name is originally > retrived as widechar string. This isn't the cleanest way, but still one > that works. > > gothas: enumerate_values is no longer usable for other maens, yet this > was its only use; reg_key_exists becomes unused; {g,s}et_app_reg_key > copy a lot of existing code, instead of reusing > > minor note: winecfg could use a better check for KEY_WOW64_32KEY case - > in my experience, it's quite often that key created by winecfg should > actually under Wow6432Node, otherwise it has no effect. > > v2: no real changes, just a cast to silence a warning and a non-patch > bit I've missed > > Signed-off-by: Rafał Mużyło > It seems to me like it'd be simpler just to do everything in Unicode.