From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH] ddraw/tests: Disable a test that causes heap corruption on some Nvidia.
Message-Id: <CAOsNvwxf_ndeN+wYVoH_n=BCEBxC92S5917AUCfURnMK--ZQdQ@mail.gmail.com>
Date: Mon, 6 Jan 2020 17:28:33 +0330
In-Reply-To: <558F1E95-C7B0-4867-AA4A-7EFF4FEA1E48@gmail.com>
References: <20200102225437.171633-1-stefan@codeweavers.com> <CAOsNvwy=mdY8ddAWM5SY=KXSXbhXn2YKXYP7QZuZZW7Pkr-5oQ@mail.gmail.com> <558F1E95-C7B0-4867-AA4A-7EFF4FEA1E48@gmail.com>

On Sat, 4 Jan 2020 at 00:20, Stefan Dösinger <stefandoesinger@gmail.com> wrote:
> > Am 03.01.2020 um 13:00 schrieb Henri Verbeet <hverbeet@gmail.com>:
> > On Fri, 3 Jan 2020 at 02:25, Stefan Dösinger <stefan@codeweavers.com> wrote:
> >> +    if (0)
> > Should that then be "if (!ddraw_is_nvidia(ddraw))"?
> I can make it so if you want, but I wouldn't put my hand in a fire that it really is an Nvidia issue and not a random corruption that can affect other systems too, but doesn't in my computer zoo by luck. The part that Deus Ex cares about is that the surface destruction does not crash.

Yeah, understood. I'm inclined to go for the narrower option and
expand it if that turns out to be necessary, instead of disabling the
test right away.