From: Zebediah Figura <z.figura12@gmail.com>
Subject: Re: [PATCH v2 3/5] d3d9: Handle multisample depth resolve in d3d9_device_SetRenderState().
Message-Id: <46ce6b62-15f5-57e1-041d-170b4991838f@gmail.com>
Date: Fri, 13 Dec 2019 09:50:39 -0600
In-Reply-To: <CAOsNvwyFnU-8Ry_msEiL+VfuqeicpytyMP4m501QYpT9417JFg@mail.gmail.com>
References: <20191211034354.809085-1-z.figura12@gmail.com> <20191211034354.809085-3-z.figura12@gmail.com> <CAOsNvwyFnU-8Ry_msEiL+VfuqeicpytyMP4m501QYpT9417JFg@mail.gmail.com>

On 12/12/19 7:44 AM, Henri Verbeet wrote:
> On Wed, 11 Dec 2019 at 07:16, Zebediah Figura <z.figura12@gmail.com> wrote:
>> @@ -289,8 +289,18 @@ static HRESULT WINAPI d3d9_CheckDeviceFormat(IDirect3D9Ex *iface, UINT adapter,
>>      }
>>
>>      wined3d_mutex_lock();
>> -    hr = wined3d_check_device_format(d3d9->wined3d, adapter, device_type, wined3dformat_from_d3dformat(adapter_format),
>> -            usage, bind_flags, wined3d_rtype, wined3dformat_from_d3dformat(format));
>> +    if ((enum wined3d_format_id)format == WINED3DFMT_RESZ)
>> +    {
>> +        DWORD levels;
>> +        hr = wined3d_check_device_multisample_type(d3d9->wined3d, adapter, device_type,
>> +                WINED3DFMT_D24_UNORM_S8_UINT, FALSE, WINED3D_MULTISAMPLE_NONE, &levels);
> Did you intend to use WINED3D_MULTISAMPLE_NON_MASKABLE here?

Yes, on further examination I did mean to do that. Thanks.

> 
> It seems a little superfluous to export
> wined3d_device_resolve_depth_buffer(); the implementation on top of
> wined3d_device_resolve_sub_resource() wasn't that complicated.
> 

Okay, I'll revert back to that implementation. I misread your earlier
response to imply that duplicating between d3d8 and d3d9 would be
dispreferred.