From: Nikolay Sivov <nsivov@codeweavers.com>
Subject: Re: [PATCH v3 3/3] xmllite: Expand test for any unparsed data at end of XML.
Message-Id: <c570f623-7b2c-2fc5-0232-cc68a2bb6602@codeweavers.com>
Date: Fri, 6 Dec 2019 20:16:29 +0300
In-Reply-To: <20191205195326.928106-3-whydoubt@gmail.com>
References: <20191205195326.928106-1-whydoubt@gmail.com> <20191205195326.928106-3-whydoubt@gmail.com>

On 12/5/19 10:53 PM, Jeff Smith wrote:
> @@ -2662,7 +2663,7 @@ static HRESULT reader_parse_nextnode(xmlreader *reader)
>               hr = reader_parse_misc(reader);
>               if (hr != S_FALSE) return hr;
>   
> -            if (*reader_get_ptr(reader))
> +            if (buffer->cur*sizeof(WCHAR) < buffer->written)
>               {
>                   WARN("found garbage in the end of XML\n");
>                   return WC_E_SYNTAX;
That means we don't have enough data, it's another change not backed by 
tests and potentially depending on current read-ahead buffer size/filled 
level.