From: "Conor McCarthy" <cmccarthy@codeweavers.com>
Subject: Re: [PATCH v3 2/7] wined3d: Add functions to support device local and non-local memory info management.
Message-Id: <858ad184094324ac1416f82e8fb4b44f@codeweavers.com>
Date: Mon, 02 Dec 2019 08:44:06 +0000
In-Reply-To: <CAOsNvwzPn33MF2oEmAYuCdLSDO9DJtJi6ZZKM_ej11LUnir9TA@mail.gmail.com>
References: <CAOsNvwzPn33MF2oEmAYuCdLSDO9DJtJi6ZZKM_ej11LUnir9TA@mail.gmail.com> <20191125141101.85701-1-cmccarthy@codeweavers.com> <20191125141101.85701-2-cmccarthy@codeweavers.com>

November 27, 2019 6:01 AM, "Henri Verbeet" <hverbeet@gmail.com> wrote:
> On Mon, 25 Nov 2019 at 17:43, Conor McCarthy <cmccarthy@codeweavers.com> wrote:
> 
> Is it ever necessary to override the total amount of video memory? 
> 

If the totals come from adapter_vk they will be correct, but adapter_gl won't have the non-local total. Should a zero total be overridden by a non-zero one? Also should totals be passed in a separate call? That could be done using a more generic messaging callback function.

> If we have wined3d_get_adapter_memory_info(), the memory information
> in struct wined3d_adapter_identifier becomes redundant and could be
> removed.

Should vram_bytes and sysmem_bytes stay in wined3d_driver_info though?

Conor