From: Henri Verbeet Subject: Re: [PATCH vkd3d 2/2] vkd3d: Return valid node masks in external resource heap properties. Message-Id: Date: Mon, 18 Nov 2019 13:01:00 +0330 In-Reply-To: <8b20a4ca46cfd15077d5f309f6774f5f@codeweavers.com> References: <20191113144829.19536-1-cmccarthy@codeweavers.com> <20191113144829.19536-2-cmccarthy@codeweavers.com> <8b20a4ca46cfd15077d5f309f6774f5f@codeweavers.com> On Mon, 18 Nov 2019 at 07:01, Conor McCarthy wrote: > November 16, 2019 4:47 AM, "Henri Verbeet" wrote: > > It should be trivial to write a corresponding test for this, correct? > > They should already be in your assigned patches: > https://source.winehq.org/patches/data/173675 > > The tests are best done in Wine, where the swapchain and buffers are created. That's doesn't work for the purposes of a vkd3d regression test; vkd3d can't depend on the tests for any particular external user of vkd3d being run before each commit is pushed. Having the d3d12 test is fine, but it serves a different purpose than a vkd3d test would.