From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d v2] vkd3d: Add an optional memory info callback extension.
Message-Id: <CAOsNvwzYq79=n=4gdS+adjHYvQ+5ON6fZTBKAA3Mxr9f3ZvOmA@mail.gmail.com>
Date: Mon, 18 Nov 2019 13:00:55 +0330
In-Reply-To: <075c08db653648f61f04f6f9f85237ca@codeweavers.com>
References: <20191114134234.7806-1-cmccarthy@codeweavers.com> <CAOsNvwxWjO7CgLe3x+LFRHjdzWeDKOTf7rog9QeLfzzo_=Of8g@mail.gmail.com> <075c08db653648f61f04f6f9f85237ca@codeweavers.com>

On Mon, 18 Nov 2019 at 11:38, Conor McCarthy <cmccarthy@codeweavers.com> wrote:
> November 16, 2019 4:56 AM, "Henri Verbeet" <hverbeet@gmail.com> wrote:
> > On Thu, 14 Nov 2019 at 17:14, Conor McCarthy <cmccarthy@codeweavers.com> wrote:
> >> +typedef void (STDMETHODCALLTYPE *PFN_vkd3d_memory_usage_callback)(IUnknown *adapter,
> >> + unsigned int non_local, UINT64 total, UINT64 usage);
> >> +
> >> +struct vkd3d_optional_device_callback_info
> >> +{
> >> + enum vkd3d_structure_type type;
> >> + const void *next;
> >> +
> >> + PFN_vkd3d_memory_usage_callback pfn_memory_usage_callback;
> >> +};
> >
> > Perhaps it makes sense to expose the totals in some form, but I'd
> > argue that for wined3d the deltas would be more natural.
>
> In that case it may make more sense to remove the total from vkd3d for now, and warn about excessive allocation in wined3d instead. What do you think?

Sure.