From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d 2/2] vkd3d: Return valid node masks in external resource heap properties.
Message-Id: <CAOsNvwyycTOtLx-EuS6Aa60dgo4uQgDoQr9PKsWXKbQm-GMQDA@mail.gmail.com>
Date: Fri, 15 Nov 2019 22:17:21 +0330
In-Reply-To: <20191113144829.19536-2-cmccarthy@codeweavers.com>
References: <20191113144829.19536-1-cmccarthy@codeweavers.com> <20191113144829.19536-2-cmccarthy@codeweavers.com>

On Wed, 13 Nov 2019 at 18:34, Conor McCarthy <cmccarthy@codeweavers.com> wrote:
> Hitman 2 calls GetHeapProperties() for each swapchain buffer and checks if
> the creation node mask is 1. If not then it fails to store the resource
> pointers for later rendering.
>
> Signed-off-by: Conor McCarthy <cmccarthy@codeweavers.com>
> ---
>  libs/vkd3d/resource.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c
> index e93d50b..45a80af 100644
> --- a/libs/vkd3d/resource.c
> +++ b/libs/vkd3d/resource.c
> @@ -1518,6 +1518,8 @@ static HRESULT STDMETHODCALLTYPE d3d12_resource_GetHeapProperties(ID3D12Resource
>          {
>              memset(heap_properties, 0, sizeof(*heap_properties));
>              heap_properties->Type = D3D12_HEAP_TYPE_DEFAULT;
> +            heap_properties->CreationNodeMask = 1;
> +            heap_properties->VisibleNodeMask = 1;
>          }
>          if (flags)
>              *flags = D3D12_HEAP_FLAG_NONE;

It should be trivial to write a corresponding test for this, correct?