From: "Erich E. Hoover" <erich.e.hoover@gmail.com>
Subject: Re: [PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.
Message-Id: <CAEU2+voqmxRas-7_evo3=WU1M78frNOp27Z+Wo=sZkzMqrdotg@mail.gmail.com>
Date: Fri, 18 Oct 2019 09:40:06 -0600
In-Reply-To: <c4ff16fa-db0f-226a-31ae-444dc68b14a4@gmail.com>
References: <CAEU2+vqfhvQRLW9wTzRNVFPA9ep-BjDb36Tj5E3M3wwbHBGjbw@mail.gmail.com> <5bcb4ab2-17a0-0d14-4ca0-73c4b7094991@gmail.com> <CAEU2+vob0Wm384knmoKnYgrTJ=VSCScygg+7SjDD59Cbky7VwQ@mail.gmail.com> <c4ff16fa-db0f-226a-31ae-444dc68b14a4@gmail.com>

Hi Piotr,

I just ran the widecharstring case on the testbot (
https://testbot.winehq.org/JobDetails.pl?Key=57989 ) and that seems to
return 0 instead of WEOF...  Are you alright with just adding this
test to demonstrate that it doesn't work the same way?  Failing test:
===
    buffer[0] = ' ';
    buffer[1] = '\t';
    buffer[2] = '\n';
    buffer[3] = '\n';
    buffer[4] = 0;
    ret = swscanf(buffer, formats, results);
    ok( ret == (short)WEOF, "ret = %d\n", ret );
===

Best,
Erich

On Fri, Oct 18, 2019 at 3:49 AM Piotr Caban <piotr.caban@gmail.com> wrote:
>
> Hi Erich,
>
> On 10/17/19 5:41 PM, Erich E. Hoover wrote:
> > +                    /* if we have reached the EOF and output nothing then report EOF */
> > +                    if (nch==_EOF_  && rd==0 && st==0) {
> _UNLOCK_FILE_(file);
> > +                        return _EOF_RET;
> > +                    }
>
> Please also update the widecharstring case.
>
> > +    fp = fopen(file_name, "wb");
> > +    ok(fp, "fp = %p\n", fp);
> This cause compilation warning.
>
> Thanks,
> Piotr