From: Zebediah Figura <z.figura12@gmail.com>
Subject: Re: [PATCH 1/2] quartz/videorenderer: Get rid of CreateRenderingSubsystem().
Message-Id: <5c65f657-c315-95a0-f130-8c1afb6aca0b@gmail.com>
Date: Fri, 18 Oct 2019 09:50:29 -0500
In-Reply-To: <e0bfd883950cec8c0024de1ed4a22677@codeweavers.com>
References: <20191018041640.24971-1-z.figura12@gmail.com> <e0bfd883950cec8c0024de1ed4a22677@codeweavers.com>

On 10/18/2019 12:34 AM, Chip Davis wrote:
> October 17, 2019 11:17 PM, "Zebediah Figura" <z.figura12@gmail.com> wrote:
> 
>> diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c
>> index 87365d9212..f4d6945380 100644
>> --- a/dlls/quartz/videorenderer.c
>> +++ b/dlls/quartz/videorenderer.c
>> @@ -873,8 +858,11 @@ HRESULT VideoRenderer_create(IUnknown *outer, void **out)
>>      if (FAILED(hr))
>>          goto fail;
>>
>> -    if (!CreateRenderingSubsystem(pVideoRenderer)) {
>> -        hr = E_FAIL;
>> +    pVideoRenderer->hEvent = CreateEventW(NULL, TRUE, FALSE, NULL);
>> +
>> +    if (FAILED(BaseWindowImpl_PrepareWindow(&pVideoRenderer->baseControlWindow.baseWindow)))
> 
> I think you want to set 'hr' here.

I consciously didn't so as to preserve the current behaviour, but it is
better that way. I'll send an updated patch.

> 
>> +    {
>> +        CloseHandle(pVideoRenderer->hEvent);
>>          goto fail;
>>      }
>>
>> -- 
>> 2.23.0
> 
> 
> Chip
>