From: Piotr Caban <piotr.caban@gmail.com>
Subject: Re: [PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.
Message-Id: <c4ff16fa-db0f-226a-31ae-444dc68b14a4@gmail.com>
Date: Fri, 18 Oct 2019 11:47:59 +0200
In-Reply-To: <CAEU2+vob0Wm384knmoKnYgrTJ=VSCScygg+7SjDD59Cbky7VwQ@mail.gmail.com>
References: <CAEU2+vqfhvQRLW9wTzRNVFPA9ep-BjDb36Tj5E3M3wwbHBGjbw@mail.gmail.com> <5bcb4ab2-17a0-0d14-4ca0-73c4b7094991@gmail.com> <CAEU2+vob0Wm384knmoKnYgrTJ=VSCScygg+7SjDD59Cbky7VwQ@mail.gmail.com>

Hi Erich,

On 10/17/19 5:41 PM, Erich E. Hoover wrote:
> +                    /* if we have reached the EOF and output nothing then report EOF */
> +                    if (nch==_EOF_  && rd==0 && st==0) {
_UNLOCK_FILE_(file);
> +                        return _EOF_RET;
> +                    }

Please also update the widecharstring case.

> +    fp = fopen(file_name, "wb");
> +    ok(fp, "fp = %p\n", fp);
This cause compilation warning.

Thanks,
Piotr