From: Micah N Gorrell Subject: Re: [PATCH resend 4/8] sechost: Implement I_ScRegisterDeviceNotification() Message-Id: <20191017181928.GH87643@dent> Date: Thu, 17 Oct 2019 12:19:28 -0600 In-Reply-To: References: <20191017145317.1998353-1-mgorrell@codeweavers.com> <20191017145317.1998353-4-mgorrell@codeweavers.com> On Thu, Oct 17, 2019 at 08:53:05PM +0300, Nikolay Sivov wrote: > I don't remember if this was already discussed for this particular patchset, > RPC interface svcctl was updated at some point to better match published MS > prototypes, see [1]. If your new methods are custom comparing to current > docs, I think it's better to register separate interface than making it > differ more than it already does. What do you mean by "register separate interface"? I think, but am not sure, that MS does have matching methods. My initial goal was to match them as closely as possible but I wasn't able to determine what the MS version actually looks like. Cheers, Micah