From: Nikolay Sivov Subject: Re: [PATCH resend 4/8] sechost: Implement I_ScRegisterDeviceNotification() Message-Id: Date: Thu, 17 Oct 2019 20:53:05 +0300 In-Reply-To: <20191017145317.1998353-4-mgorrell@codeweavers.com> References: <20191017145317.1998353-1-mgorrell@codeweavers.com> <20191017145317.1998353-4-mgorrell@codeweavers.com> On 10/17/19 5:53 PM, Micah N Gorrell wrote: > + > + /* Not compatible with Windows function 57 */ > + DWORD svcctl_OpenDeviceNotificationHandle( > + [in, string, unique] SVCCTL_HANDLEW machinename, > + [out] SC_DEV_NOTIFY_RPC_HANDLE *handle); > + > + /* Not compatible with Windows function 58 */ > + DWORD svcctl_GetDeviceNotificationResults( > + [in] SC_DEV_NOTIFY_RPC_HANDLE handle, > + [out] DWORD *event_code, > + [out, size_is(,*event_size)] BYTE **event, > + [out] DWORD *event_size); > } I don't remember if this was already discussed for this particular patchset, RPC interface svcctl was updated at some point to better match published MS prototypes, see [1]. If your new methods are custom comparing to current docs, I think it's better to register separate interface than making it differ more than it already does. [1] https://source.winehq.org/git/wine.git/commit/0f80d4b61966af776365486c139c3e6238b984d9