From: Jacek Caban <jacek@codeweavers.com>
Subject: Re: [PATCH 2/9] vbscript: Store the DISPID for functions and variables.
Message-Id: <f9a43315-77a4-5cec-11f1-19a7e30ba339@codeweavers.com>
Date: Wed, 16 Oct 2019 15:22:41 +0200
In-Reply-To: <2ed8f6d684ae5a3e33abb506c259bc0e5509aeed.1571150960.git.gabrielopcode@gmail.com>
References: <c348d81252067997251211458ea5216c325290a9.1571150960.git.gabrielopcode@gmail.com> <2ed8f6d684ae5a3e33abb506c259bc0e5509aeed.1571150960.git.gabrielopcode@gmail.com>

Hi Gabriel,

On 10/15/19 4:54 PM, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu<gabrielopcode@gmail.com>
> ---
>
> This will be needed for next patch to build the TypeInfo properly, as the
> DISPIDs have to match with MEMBERIDs.


Storing it like that indeed seems to make sense. However, if we're going 
to do that, we should probably calculate those DISPIDs in the compiler 
and get rid of ident_map_t.


Thanks,

Jacek