From: Alex Henrie <alexhenrie24@gmail.com>
Subject: Re: [PATCH] winex11: Initialize biCompression in create_icon_pixmaps (Valgrind)
Message-Id: <CAMMLpeT_+S_NHEevO7X5pD=+jX+sO+1mKaY66UhPQASUoiY7Bw@mail.gmail.com>
Date: Tue, 15 Oct 2019 11:49:09 -0600
In-Reply-To: <87pniyvxlx.fsf@wine>
References: <20191014034454.48511-1-alexhenrie24@gmail.com> <87pniyvxlx.fsf@wine>

On Tue, Oct 15, 2019 at 9:26 AM Alexandre Julliard <julliard@winehq.org> wrote:
>
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > create_icon_pixmaps calls GetDIBits, which checks biCompression and
> > returns early if the value is incorrect.
>
> No, the code may not be obvious, but it does the right thing.

You're right, create_icon_pixmaps calls GetDIBits with bits set to
NULL, so biCompression is never checked. Thanks for noticing that.
Sadly it means that something even more obscure is causing the
Valgrind warnings :-(

-Alex