From: Dmitry Timoshkov Subject: Re: [PATCH] msxml3/tests: Add IXMLDOMNode::selectSingleNode() test for an XML with multiple namespaces. Message-Id: <20191009164619.eb8fa741391fc64b3809da4e@baikal.ru> Date: Wed, 9 Oct 2019 16:46:19 +0800 In-Reply-To: References: <20191007105950.3e9321430cd4520d95fb60d6@baikal.ru> <19a96dbd-97bd-e3dc-39b3-762591bb41f6@codeweavers.com> <20191009161848.82dfd4e88069057391ee9313@baikal.ru> Nikolay Sivov wrote: > >> Please use existing function for this. > > I considered that, however existing test_selectSingleNode() is cluttered > > by failure cases, and finally doesn't test anything useful. Using it as > > a place for new tests would add even more mess. I'd prefer to make new tests > > for multiple namespaces a separate test, which could be extended with new > > tests if needed. > Just append it there, and remove whatever you think is broken with > existing tests. Having separate functions for every occasion is worse. There's nothing broken in exising tests, they are just a cluttered mess. Adding new tests to the end of a mess is not very nice IMO. What's wrong with having separate bodies for very different tests? -- Dmitry.