From: Nikolay Sivov <nsivov@codeweavers.com>
Subject: Re: [PATCH] msxml3/tests: Add IXMLDOMNode::selectSingleNode() test for an XML with multiple namespaces.
Message-Id: <f28ab250-aba9-1ac9-73a9-a0f510931efd@codeweavers.com>
Date: Wed, 9 Oct 2019 11:39:36 +0300
In-Reply-To: <20191009161848.82dfd4e88069057391ee9313@baikal.ru>
References: <20191007105950.3e9321430cd4520d95fb60d6@baikal.ru> <19a96dbd-97bd-e3dc-39b3-762591bb41f6@codeweavers.com> <20191009161848.82dfd4e88069057391ee9313@baikal.ru>

On 10/9/19 11:18 AM, Dmitry Timoshkov wrote:

> Nikolay Sivov <nsivov@codeweavers.com> wrote:
>
>> Please use existing function for this.
> I considered that, however existing test_selectSingleNode() is cluttered
> by failure cases, and finally doesn't test anything useful. Using it as
> a place for new tests would add even more mess. I'd prefer to make new tests
> for multiple namespaces a separate test, which could be extended with new
> tests if needed.
Just append it there, and remove whatever you think is broken with 
existing tests. Having separate functions for every occasion is worse.