From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d 1/2] vkd3d-shader: Optimize get_opcode_info with direct opcode_table access.
Message-Id: <CAOsNvwyPA7HnNBdXn=kVOjdHV5dSdzFpfepupLDUi-ssL-azDQ@mail.gmail.com>
Date: Thu, 3 Oct 2019 22:35:00 +0330
In-Reply-To: <20191003170933.12734-1-rbernon@codeweavers.com>
References: <20191003170933.12734-1-rbernon@codeweavers.com>

On Thu, 3 Oct 2019 at 20:42, Rémi Bernon <rbernon@codeweavers.com> wrote:
> The shader_sm4_read_instruction function shows up in perf report when
> running SOTTR on Intel because of this loop.
>
That seems like a questionable claim. Does this actually improve
things? Do you have numbers? Direct3D 12 applications should ideally
not be creating pipeline states at all during rendering, but if they
do, actual shader compilation is going to be much more expensive than
anything we do here.

That's not to say this can't be improved though.