From: Brendan Shanks <bshanks@codeweavers.com>
Subject: Re: [PATCH] ntdll: Always add a tail to heap allocations.
Message-Id: <F9D91E06-E5E7-4206-ADFA-83FF48FAB651@codeweavers.com>
Date: Thu, 19 Sep 2019 23:16:55 -0700
In-Reply-To: <20190920095956.f13a3b3ebe0b9247b1a5cb4c@baikal.ru>
References: <20190919223935.22589-1-bshanks@codeweavers.com> <20190920095956.f13a3b3ebe0b9247b1a5cb4c@baikal.ru>


> On Sep 19, 2019, at 6:59 PM, Dmitry Timoshkov <dmitry@baikal.ru> wrote:
> 
> Brendan Shanks <bshanks@codeweavers.com> wrote:
> 
>> Fixes the Rockstar Games Launcher installer (and possibly other
>> NSIS-based installers) from crashing due to passing a too-small buffer
>> to GetWindowInfo().
> 
> Obviously GetWindowInfo() should be fixed instead. Also some test cases
> wouldn't hurt either.

Unfortunately GetWindowInfo() already works as it does on Windows: cbSize is ignored, and it always writes 60 bytes into the provided buffer. You’re right that there should be tests to prove this though, I’ll work on that. The linked bug report has some extra detail about the problem.

Brendan