From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH vkd3d v2 1/6] tests: Test ClearRenderTargetView() with R8G8B8A8_{SINT, UINT} formats.
Message-Id: <CAOsNvwxZfG3mnmhnkP0p+M9A5TPDDdjtAbPdXJGeRTyuzKDSzg@mail.gmail.com>
Date: Thu, 18 Jul 2019 14:18:13 +0430
In-Reply-To: <20190717111737.874-1-joseph.kucia@gmail.com>
References: <20190717111737.874-1-joseph.kucia@gmail.com>

On Wed, 17 Jul 2019 at 15:48, Józef Kucia <joseph.kucia@gmail.com> wrote:
> @@ -4311,6 +4328,30 @@ static void test_clear_render_target_view(void)
>      unsigned int i;
>      D3D12_BOX box;
>      HRESULT hr;
> +    static const struct
> +    {
> +        const float *color;
> +        unsigned int expected;
> +        unsigned int max_diff;
> +        bool is_todo;
> +    }
> +    test_r8g8b8a8_unorm[] =
> +    {
> +        {green, 0xff00ff00, 0},
> +        {color, 0xbf4c7f19, 2},
> +    },
> +    test_r8g8b8a8_uint[] =
> +    {
> +        {green, 0x01000100, 0, true},
> +        {color, 0x00000000, 0, true},
> +        {negative_value, 0x00000001, 0, true},
> +    },
> +    test_r8g8b8a8_sint[] =
> +    {
> +        {green, 0x01000100, 0, true},
> +        {color, 0x00000000, 0, true},
> +        {negative_value, 0xfe00ff01, 0, true},
> +    };
Do you need these to be separate arrays? It seems that only the view
format is different between them.