From: Alexandre Julliard Subject: Re: [PATCH] kerberos: Fix compilation on systems where SONAME_LIBKRB5 is not defined. Message-Id: <87a7du41o9.fsf@wine> Date: Thu, 04 Jul 2019 10:57:42 +0200 In-Reply-To: <20190704163440.711d3f8cef120e2ca6a00e43@baikal.ru> (Dmitry Timoshkov's message of "Thu, 4 Jul 2019 16:34:40 +0800") References: <20190702110526.29839fa3f058de521e92d7d3@baikal.ru> <1562054208.14568.12.camel@codeweavers.com> <20190702170238.9739f7bf5b3153c64709ced2@baikal.ru> <1562062097.14568.14.camel@codeweavers.com> <20190702181427.7658cf2ebc83418b13376e24@baikal.ru> <1562064101.14568.16.camel@codeweavers.com> <20190702185016.8c7e6fb48a69c7fd0a8a21ce@baikal.ru> <877e8zgehu.fsf@wine> <20190704163440.711d3f8cef120e2ca6a00e43@baikal.ru> Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > Hans Leidekker wrote: >> > >> >> On Tue, 2019-07-02 at 18:14 +0800, Dmitry Timoshkov wrote: >> >> > Sounds like a broken install. To fix this I think it would be better to improve >> >> > > our configure check than to add more (nested) ifdefs. >> >> > >> >> > I believe that the added ifdefs are actually necessary, and they logically >> >> > separate libkrb5 functionality from libgssapi one. Without libkrb5 the only >> >> > things that won't be supported are custom credentials and the ticket cache, >> >> > everything else works just fine. >> >> > >> >> > > AcquireCredentialsHandle won't be very useful without these krb5 functions. >> >> > >> >> > It works just fine with cached system credentials. >> >> >> >> gssapi itself depends on krb5, so there's no reason to build with partial support. >> > >> > Apparently there are configurations where that's not the case, and supporting them >> > isn't that hard as the patch shows. >> >> Have you verified that the library is truly missing, or is it only the >> .so symlink from the dev package? > > I've relayed your question, and got the following answer: "only the dev > package with the .so symlink was missing". OK, thanks. It seems that failing at configure time with a warning is more appropriate then. -- Alexandre Julliard julliard@winehq.org